Add labelField, searchFields support for relationship field #8074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was marked as resolved.
This comment was marked as resolved.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a1fb672:
|
dcousens
force-pushed
the
ui-labelfield
branch
2 times, most recently
from
b20c0b8 to
474ebac
Compare
dcousens
changed the title
dcousens
force-pushed
the
ui-labelfield
branch
from
474ebac to
ccfeb24
Compare
emmatown
requested changes
Nov 9, 2022
There was a problem hiding this comment.
We should have validation that labelField or searchFields on relationships points to fields that work as label fields and search fields (like we do for the list-level options)
(Also, unrelated, this will be broken for users if they update fields-document without core but maybe we're fine with that?)
dcousens
force-pushed
the
ui-labelfield
branch
from
b9d018b to
abc5cc4
Compare
dcousens
force-pushed
the
ui-labelfield
branch
from
3aee41f to
7ac7767
Compare
dcousens
force-pushed
the
ui-labelfield
branch
from
282fe82 to
3749779
Compare
dcousens
force-pushed
the
ui-labelfield
branch
from
3749779 to
56d5d91
Compare
emmatown
approved these changes
Nov 15, 2022
dcousens
force-pushed
the
ui-labelfield
branch
from
916a3e8 to
a1fb672
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #8049, this feature was apparently completely undercooked.
I have now added
labelFieldsupport for each of the instances that used that functionality, and consequently thesearchFieldsfeature which is required for functionality to adhere to UX expectations.